Repository navigation
env: add zephyr support - #360
RomainPelletant wants to merge 3 commits into
Conversation
00ac9f0 to
61e6d94
Compare
|
I will consider this. In the future, please just file a PR as issue+PR is just more work for both of us... :) |
|
Thank you! Noted for next time, old habits die hard :) |
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
See comments. Mainly coding style/copyright header issues, plus I'm wondering about "west.yml" in the root directory...
| @@ -0,0 +1,17 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Is there a reason this needs to be in the root directory or present at all?
There was a problem hiding this comment.
west.yml (manifest) is not mandatory but -extremely- useful for zephyr use.
It makes the repo directly usable in two commands (west init -l . && west update) to compile/run library, sample test suite and CI.
That said, if you’d prefer not to have a west manifest in the upstream repository, I can remove it.
| @@ -0,0 +1,89 @@ | |||
| /* SPDX-License-Identifier: Apache-2.0 */ | |||
There was a problem hiding this comment.
I'd feel more comfortable if this sample code had a proper copyright header.
| #include <mxml.h> | ||
|
|
||
| static mxml_type_t value_type(void *cbdata, mxml_node_t *node) | ||
| { |
There was a problem hiding this comment.
Also (and I know I'm being anal here) any sample code should use the Mini-XML coding style - see the (newly added but largely copied from my other projects) "CONTRIBUTING.md" file that actually documents this in excruciating detail.
There was a problem hiding this comment.
my bad: updated according to guidelines!
| @@ -0,0 +1,8 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Similarly here we should have a copyright header.
| @@ -0,0 +1,27 @@ | |||
| Mini-XML basic sample | |||
There was a problem hiding this comment.
I dunno if restructured text is required/typical for Zephyr examples? The rest of Mini-XML uses markdown files for this sort of thing.
There was a problem hiding this comment.
Typical but not required: switched to markdown.
| @@ -0,0 +1,31 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| @@ -0,0 +1,34 @@ | |||
| # Copyright (c) 2026 | |||
| security: | ||
| external-references: | ||
| - cpe:2.3:a:msweet:mini-xml:4.0.6:*:*:*:*:*:*:* | ||
| - pkg:github/michaelrsweet/mxml@v4.0.6 |
There was a problem hiding this comment.
Is the version number associated with a tag or just information that comes along with the source archive or checkout?
Mainly asking because "makesrcdist" will check all of the files that need version numbers updated, and if this also needs to be updated I'll add a check there as well...
There was a problem hiding this comment.
Both references are static metadata and needs to be updated (release version for CPE and tag for PURL).
I didn't see the makesrcdist: new commit to implement the check added to save you time.
| @@ -0,0 +1,64 @@ | |||
| Mini-XML Zephyr (as external module) | |||
There was a problem hiding this comment.
Same question as for the other .rst file...
| @@ -0,0 +1,23 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
61e6d94 to
cf98d2e
Compare
- Add zephyr support as external module - Tests and samples are located in zephyr folder to avoid propagation Signed-off-by: Romain PELLETANT <romain.pelletant@sixtaupi.com>
- Add zephyr build in common build ci workflow Signed-off-by: Romain PELLETANT <romain.pelletant@sixtaupi.com>
- Add two checks for version update in zephyr/module.yml Signed-off-by: Romain PELLETANT <romain.pelletant@sixtaupi.com>
cf98d2e to
5838e3f
Compare
|
All header issues are fixed: I used the mxml header style. |
This branch has not been deployed
2 participants
Fixes #361
Assisted-by: ChatGPT:GPT-5.6 Sol